Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add gcr.io images to publish results #4283

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Only add gcr.io images to publish results #4283

merged 1 commit into from
Oct 6, 2021

Conversation

afrittoli
Copy link
Member

@afrittoli afrittoli commented Oct 6, 2021 •
edited
Loading

Changes

The release process generates and number of container images and
publishes them to gcr.io as well as three regional versions of the
registry. Today all those images are added to the IMAGES result,
for signing by chains, however that causes the nightly build to
fail as we hit the termination message size limit.

Until we have a way to store larger results, we shall only sign
images on gcr.io as a workaround.

Workaround to #4282

Signed-off-by: Andrea Frittoli [email protected]

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Due to a technical limitation, only images published to `gcr.io`, which are included in the `release.yaml`, are signed.
Images on `eu.gcr.io`, `us.gcr.io` and `asia.gcr.io` are not signed yet.

@afrittoli
Only add gcr.io images to publish results
edd439d 
The release process generates and number of container images and
publishes them to gcr.io as well as three regional versions of the
registry. Today all those images are added to the IMAGES result,
for signing by chains, however that causes the nightly build to
fail as we hit the termination message size limit.

Until we have a way to store larger results, we shall only sign
images on gcr.io as a workaround.

Workaround to tektoncd#4282

Signed-off-by: Andrea Frittoli <[email protected]>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 6, 2021
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Oct 6, 2021
@vdemeester
Copy link
Member

Could we "split" the result into multiple bucket (that we know of) ? Like the main one, asia, europe, … ?

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2021
@afrittoli
Copy link
Member Author

Could we "split" the result into multiple bucket (that we know of) ? Like the main one, asia, europe, … ?

We could, however in my understanding we would need to run one Task per bucket then.
AFAIU the size limit applies the collection of results, so event having more results in one Task would not help.
Chains only supports one IMAGES list result and many individual ones. We could add support having multiple lists, but again that would not help with the size limitation.

@pritidesai
Copy link
Member

/lgtm

would it be overkill to run publish task one per region? 😲

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2021
@tekton-robot tekton-robot merged commit 75f4762 into tektoncd:main Oct 6, 2021
@pritidesai
Copy link
Member

I would like to cherry pick this in v0.28.x. I believe there is no need to create a separate patch since this is something consumed by the dogfooding cluster and not user facing. I have updated the definition on the dogfooding cluster while creating v0.28.2 after cherry picking this change.

@pritidesai pritidesai added the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Oct 14, 2021
@ghost ghost removed the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@pritidesai pritidesai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afrittoli @vdemeester @tekton-robot @pritidesai